Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Expand Images not working on local and protected websites [ED-14927] #27489

Merged
merged 2 commits into from
May 26, 2024

Conversation

netanelavr
Copy link
Member

@netanelavr netanelavr commented May 26, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

  • Fix: Expand Images not working on local and protected websites

Description

An explanation of what is done in this PR

  • send the image from the client side encoded as base64
  • update ai request params

Test instructions

This PR can be tested by following these steps:

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • Docs have been added / updated (for bug fixes / features)

Fixes #

@netanelavr netanelavr merged commit 6215e67 into elementor:main May 26, 2024
52 checks passed
netanelavr added a commit to netanelavr/elementor that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants