Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #617 : Raise DBUS_TIMEOUT_MSEC value in src/Helpers/InstallerDaemon.vala #701

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

aerocyber
Copy link
Contributor

@danirabbit danirabbit requested a review from a team April 10, 2023 19:05
src/Helpers/InstallerDaemon.vala Outdated Show resolved Hide resolved
src/Helpers/InstallerDaemon.vala Outdated Show resolved Hide resolved
src/Helpers/InstallerDaemon.vala Outdated Show resolved Hide resolved
Update the file to match the suggestions.
@aerocyber
Copy link
Contributor Author

Can you please guide me with the linting error?

@lenemter
Copy link
Member

@aerocyber There is a trailing whitespace at line 21. Probably it's inserted automatically by your text editor when you press enter.

@aerocyber
Copy link
Contributor Author

Alright, thank you, will fix it now.

@aerocyber aerocyber requested a review from lenemter April 11, 2023 12:48
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for this one. 🚀

@lenemter lenemter merged commit dfb4a85 into elementary:master Apr 11, 2023
@aerocyber
Copy link
Contributor Author

Thank you for your help and time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer not showing disk or partitions, can't install.
2 participants