Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance of check_state_groups_and_bump_deletion #18141

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

erikjohnston
Copy link
Member

Regressed as part of #18107

This does two things:

  1. Only check if the state groups have been deleted when calculating the event context (as that's when we will insert them). This avoids lots of checks for read operations.
  2. Don't lock the state_groups rows when doing the check. This adds overhead, and it doesn't prevent any races.

@erikjohnston erikjohnston marked this pull request as ready for review February 6, 2025 16:15
@erikjohnston erikjohnston requested a review from a team as a code owner February 6, 2025 16:15
Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks clean. Added comments are nice.
The logic changes make sense to me. But I also approved the previous PRs that got us into this state in the first place... :)

@erikjohnston erikjohnston changed the base branch from develop to release-v1.124 February 7, 2025 09:06
@erikjohnston erikjohnston merged commit dcf7b39 into release-v1.124 Feb 7, 2025
39 checks passed
@erikjohnston erikjohnston deleted the erikj/fix_perf_deletion branch February 7, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants