Remove SYNAPSE_USE_FROZEN_DICTS environment variable
#18123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MadLittleMods
commented
Jan 31, 2025
Comment on lines
-56
to
-62
| # Whether we should use frozen_dict in FrozenEvent. Using frozen_dicts prevents | ||
| # bugs where we accidentally share e.g. signature dicts. However, converting a | ||
| # dict to frozen_dicts is expensive. | ||
| # | ||
| # NOTE: This is overridden by the configuration by the Synapse worker apps, but | ||
| # for the sake of tests, it is set here while it cannot be configured on the | ||
| # homeserver object itself. |
There was a problem hiding this comment.
Moved this to a comment doc so the information appears on hover.
MadLittleMods
commented
Jan 31, 2025
|
|
||
| USE_FROZEN_DICTS = strtobool(os.environ.get("SYNAPSE_USE_FROZEN_DICTS", "0")) |
There was a problem hiding this comment.
I got rid of the SYNAPSE_USE_FROZEN_DICTS environment variable because it will be overridden by the Synapse worker apps anyway and if we want to support SYNAPSE_USE_FROZEN_DICTS, it should be in synapse/config/server.py. It's also not documented so I'm assuming no one is using it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
SYNAPSE_USE_FROZEN_DICTSenvironment variableI got rid of the
SYNAPSE_USE_FROZEN_DICTSenvironment variable because it will be overridden by the Synapse worker apps anyway and if we want to supportSYNAPSE_USE_FROZEN_DICTS, it should be insynapse/config/server.py. It's also not documented so I'm assuming no one is using it anyway.Spawning from looking at the frozen dict stuff during the review of #18103 (comment)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)