Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the session list and details view #4029

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Feb 13, 2025

This is another round of alignment with the design.

A few things this does:

  • simplify the session details view, using composable components, instead of a big 'SessionDetails' component with many props
  • factors out the 'end session' buttons for each session type, meaning that the dialog content is the same whether we're ending the session from the session details view or the session list view
  • rename 'sign out' to 'remove device', and 'sign out' with 'sign out of account'
  • move the sign out button to the bottom of the main page
  • remove some unnecessary abstractions, like 'BlockList' and 'Block'
  • use the 'VisualList' from compound, remove our own implementation
  • make sure the page doesn't overflow the screen with big device IDs
  • use the device name/client name as much as possible instead of the device ID
  • remove the navigation/greeting layout from the session details view

Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2025

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50e2693
Status: ✅  Deploy successful!
Preview URL: https://4a53501a.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-design-review-feb-2.matrix-authentication-service-docs.pages.dev

View logs

@sandhose sandhose force-pushed the quenting/design-review-feb-25 branch from c8167b7 to ee04b08 Compare February 13, 2025 14:57
@sandhose sandhose changed the title Polish the session details Polish the session list and details view Feb 13, 2025
@sandhose sandhose force-pushed the quenting/design-review-feb-25 branch from ee04b08 to 1ed9586 Compare February 13, 2025 15:16
@sandhose sandhose added A-Account-Management Related to self-service account management A-Device-Management Related to sessions and device management A-Frontend Changes on the React frontend T-Enhancement New feature of request labels Feb 13, 2025
@sandhose sandhose enabled auto-merge February 13, 2025 15:37
@sandhose sandhose disabled auto-merge February 13, 2025 15:37
@sandhose sandhose enabled auto-merge February 13, 2025 15:55
@sandhose sandhose merged commit 2234629 into main Feb 13, 2025
24 checks passed
@sandhose sandhose deleted the quenting/design-review-feb-25 branch February 13, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Account-Management Related to self-service account management A-Device-Management Related to sessions and device management A-Frontend Changes on the React frontend T-Enhancement New feature of request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant