Allow fetching user claims through the userinfo_endpoint for upstream OAuth 2.0 providers
#3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
1903904 to
4a62a23
Compare
sandhose
reviewed
Oct 15, 2024
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
2 times, most recently
from
c59ee5b to
4a62a23
Compare
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
4a62a23 to
d4f4c95
Compare
sandhose
reviewed
Oct 31, 2024
crates/storage-pg/migrations/20241014145741_upstream_oauth_userinfo.sql
Outdated
Show resolved
Hide resolved
sandhose
reviewed
Oct 31, 2024
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
d4f4c95 to
9f3ac54
Compare
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
9f3ac54 to
7c73cf6
Compare
|
Could we unleash the CI please :) ? |
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
2 times, most recently
from
a4e6e78 to
63e680d
Compare
sandhose
requested changes
Nov 21, 2024
| lazy_metadata.userinfo_endpoint().await?, | ||
| response.access_token.as_str(), | ||
| Some(verification_data), | ||
| &id_token_map.ok_or(RouteError::MissingIDToken)?, |
There was a problem hiding this comment.
Interesting, I did not know we were checking that the userinfo returns the same sub & co as the id_token… we probably want to remove that, as we'd like to support non-OIDC providers as well…
I can do that in a later PR though
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
3 times, most recently
from
0de88fb to
880c7b9
Compare
MatMaul
changed the title
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
2 times, most recently
from
35ecaf6 to
1c167ac
Compare
MatMaul
force-pushed
the
add-userinfo-endpoint
branch
from
1c167ac to
5d5519f
Compare
sandhose
requested changes
Nov 26, 2024
crates/storage-pg/migrations/20241124145741_upstream_oauth_userinfo.sql
Outdated
Show resolved
Hide resolved
sandhose
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM! It just occurred to me that it's missing documentation about the new options here: https://element-hq.github.io/matrix-authentication-service/reference/configuration.html#upstream_oauth2
But I'm fine with doing this in another PR
|
Well done @MatMaul :) |
sandhose
changed the title
userinfo_endpoint for upstream OAuth 2.0 providers
sandhose
added
A-Upstream-OAuth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested for now so I am keeping it as a draft.