Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User verification state indicators #3793

Merged
merged 9 commits into from
Feb 18, 2025
Merged

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Feb 14, 2025

Fixes #3752. Best reviewed commit by commit.

Adds user verification state decorators in the following places:

  • DM room header view
  • People entry on the room details
  • Room members list on each member
  • On the room member details + a withdraw verification option when the user has a verification violation

…into an easy to digest `UserIdentityVerificationState`. Use it in a dedicated `VerificationBadge` UI component
…tity verification state violations on any of the members.
… reliable way to keep it up to date

- the underlying Rust SDK Olm Machine can be rebuilt without notice which would break any existing user identity change streams.
@stefanceriu stefanceriu requested a review from a team as a code owner February 14, 2025 12:46
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team February 14, 2025 12:46
Copy link

github-actions bot commented Feb 14, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 76042c8

@stefanceriu stefanceriu added the pr-feature for a new feature label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
930 1 929 0
View the top 1 failed test(s) by shortest run time
PreviewTests test_roomMemberDetailsScreen()
Stack Traces | 2.24s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9442749 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

Copy link

@stefanceriu stefanceriu enabled auto-merge (squash) February 18, 2025 06:37
@stefanceriu stefanceriu disabled auto-merge February 18, 2025 06:37
@stefanceriu stefanceriu merged commit f77faee into develop Feb 18, 2025
8 checks passed
@stefanceriu stefanceriu deleted the stefan/verificationBadges branch February 18, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] User verification state indicators
2 participants