Fix message completion trigger to work anywhere in the message

[vickcoo]

This PR resolves issue #3522

Pull Request Checklist

• I read the contributing guide.
• Pull request contains a changelog label.

UI changes have been tested with:

• iPhone and iPad simulators in portrait and landscape orientations.
• Dark mode enabled and disabled.
• Various sizes of dynamic type.
• Voiceover enabled.

[CLAassistant]

All committers have signed the CLA.

[stefanceriu]

Can you try testing out this new behavior within the CompletionSuggestionServiceTests?

[vickcoo]

I've run the testing on CompletionSuggestionServiceTests, and they all pass

[stefanceriu]

I've run the testing on CompletionSuggestionServiceTests, and they all pass

As in write a brand new one just for this special case and assert that the suggestions show up

[vickcoo]

Oh! Do you mean I need to write a new unit test for this?
I have no idea what happened cause the flow fail

*I apologize If my English is unclear.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (a70189d) to head (4346d9e).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3696      +/-   ##
===========================================
- Coverage    78.71%   78.68%   -0.03%     
===========================================
  Files          792      792              
  Lines        67839    67863      +24     
===========================================
- Hits         53399    53398       -1     
- Misses       14440    14465      +25     

Flag	Coverage Δ
unittests	70.27% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vickcoo]

Why did the CI/CD fail, And how can I solve the problems?

[stefanceriu]

Why did the CI/CD fail

Only the enterprise tests failed which is to be expected as you don't have access to that code, it's private.
As far as I can tell your part is good but I'll review it properly next week.

[vickcoo]

As far as I can tell your part is good but I'll review it properly next week.

I got it! thank you for your reply

[pixlwave]

Hey @vickcoo, thanks for opening your first contribution 🎉

I've just tested it out, but I think we probably need to refine it a bit more. If you type @ into the composer but don't want to mention someone it now always shows a suggestion and if you subsequently try to @mention someone it uses that first @ as the trigger so your filtering doesn't work. If we're going to allow mentioning from anywhere in the message, we really need to use the caret position as the trigger rather than iterating through all the words. See an example of the unexpected behaviour here:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-27.at.10.12.40.mp4

[vickcoo]

Hi @pixlwave! thank you for your feedback, here are a few ideas.

Solution 1
The @ symbol triggers suggestions, but the cursor must be positioned next to it, even if the message contains multiple "@" symbols.
For example, suggestions appear when the cursor is positioned at 1️⃣ or 2️⃣; otherwise, no suggestions are shown.

    1️⃣     2️⃣
    ↓      ↓
Hi @, I'm @

Solution 2
We can trigger suggestions anywhere when typing the @, and other @ will be a plain string.

[pixlwave]

Solution 1 sounds super to me if it's possible!

[pixlwave]

Thanks for the updates. I just tried this out and it is really nice! 🤩

I've added a couple of comments about the new algorithm inline, but one other thing I noticed was that if you accept a suggestion in the middle, the cursor jumps to the end of the message which might be a bit annoying:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-03.at.11.39.14.mp4

[pixlwave]

This looks and works great! There's just a small compile error to fix on the unit tests and then this will be ready to merge 👏

Edit: It's coming from SwiftGen. Make sure to swift run tools setup-project to ensure you have all the homebrew dependencies set up and then if you build the project you should see a change to the GeneratedMocks.swift that also needs to be committed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pixlwave]

Thank you very much for your contribution @vickcoo. The tests passed (but appear to fail as the coverage upload fails) so I'm going to merge this PR now 🎉

[vickcoo]

Thank you very much for your contribution @vickcoo. The tests passed (but appear to fail as the coverage upload fails) so I'm going to merge this PR now 🎉

Hi @pixlwave, Thank you for your help, and a lot of patience in helping me solve the problem! 😊

[pixlwave]

You're welcome! I've just been using this on todays Nightly build and it rocks 🙌