Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Intentional Mentions #1929

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Send Intentional Mentions #1929

merged 6 commits into from
Oct 20, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 20, 2023

This PR also updates the Rust SDK and RTE.

Now we can fetch the current state of mentions from RTE and when sending a message we can fetch this state, and use it also add intentional message to the content.

@Velin92 Velin92 requested a review from a team as a code owner October 20, 2023 12:23
@Velin92 Velin92 requested review from nimau and removed request for a team October 20, 2023 12:23
@Velin92 Velin92 linked an issue Oct 20, 2023 that may be closed by this pull request
Mentions: Send intentional mentions #1914
Closed
@Velin92 Velin92 requested a review from stefanceriu October 20, 2023 12:25
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against db93162

stefanceriu
stefanceriu approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 👌

ElementX/Sources/Services/Room/RoomProxyProtocol.swift Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 enabled auto-merge (squash) October 20, 2023 12:57
@stefanceriu stefanceriu disabled auto-merge October 20, 2023 13:51
@stefanceriu stefanceriu merged commit 1d1f76f into develop Oct 20, 2023
@stefanceriu stefanceriu deleted the mauroromito/send_intentional_mention branch October 20, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@nimau nimau Awaiting requested review from nimau nimau is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mentions: Send intentional mentions
2 participants
@Velin92 @stefanceriu