Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of en-US translations. #4135

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix import of en-US translations. #4135

merged 1 commit into from
Jan 10, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 10, 2025

Content

Fix the script that generate the config for localazy in order to be able to download English other region.

Doc: https://localazy.com/docs/cli/variables#download-variables

Motivation and context

Have en-rUS land to the app.

Screenshots / GIFs

NA

Tests

The language has been enabled on Localazy and the import is working locally. The new language will be imported in the next Localazy sync.

Tested devices

NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-i18n For translations label Jan 10, 2025
@bmarty bmarty requested a review from a team as a code owner January 10, 2025 15:08
@bmarty bmarty requested review from ganfra and removed request for a team January 10, 2025 15:08
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aecgeR

@ganfra ganfra enabled auto-merge January 10, 2025 15:12
@ganfra ganfra merged commit bcec2ef into develop Jan 10, 2025
26 checks passed
@ganfra ganfra deleted the feature/bma/en-us branch January 10, 2025 15:14
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (63dbf93) to head (f92ffbe).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4135   +/-   ##
========================================
  Coverage    83.26%   83.26%           
========================================
  Files         1885     1885           
  Lines        49127    49127           
  Branches      5774     5774           
========================================
  Hits         40907    40907           
  Misses        6144     6144           
  Partials      2076     2076           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-i18n For translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants