design : CounterAtom

[ganfra]

Content

Introduce new CounterAtom component and ListItemContent.Counter and use it for knock requests.

Motivation and context

https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=2805-2649&m=dev
https://www.figma.com/design/7TqjqdMBaPpm3IavKsMYu6/Ask-to-join-(Knocking)?node-id=5135-92555&m=dev

Screenshots / GIFs

Check new screenshots.

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pTbwDx

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (5880bbb) to head (179a9d1).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
...libraries/designsystem/atomic/atoms/CounterAtom.kt	92.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4108   +/-   ##
========================================
  Coverage    83.27%   83.28%           
========================================
  Files         1884     1885    +1     
  Lines        49068    49098   +30     
  Branches      5760     5764    +4     
========================================
+ Hits         40862    40890   +28     
  Misses        6139     6139           
- Partials      2067     2069    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks, just a small remark about a color!

[bmarty]

According to Figma, you should use ElementTheme.colors.textOnSolidPrimary (which is White so will not touch the screenshot)

[ganfra]

It's not exactly true, it's using Light/color/text/on-solid/primary for both Light and Dark theme, so I think it's clearer to use White directly...

[bmarty]

ah yes ok, so ignore me