Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media gallery UI update #4071

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Media gallery UI update #4071

merged 9 commits into from
Dec 20, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 19, 2024

Content

Small change on the media gallery following internal sync.
Figma: https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=1732-80010

Also enable the feature in production.

Motivation and context

Improve UI rendering

Screenshots / GIFs

See recorded one.

Tests

  • Open the gallery and some media

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner December 19, 2024 16:10
@bmarty bmarty requested review from ganfra and removed request for a team December 19, 2024 16:10
Copy link
Contributor

github-actions bot commented Dec 19, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UxMaye

Color.White,
)
)
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this, it has to render correctly on light theme too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bg for the info (picto + duration) displayed above the video thumbnail.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 19, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 19, 2024
@bmarty bmarty added the PR-Feature For a new feature label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 67.24138% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.10%. Comparing base (a69b04e) to head (e5a0576).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...aries/mediaviewer/impl/gallery/MediaGalleryView.kt 46.15% 5 Missing and 2 partials ⚠️
.../mediaviewer/impl/gallery/MediaGalleryPresenter.kt 0.00% 4 Missing and 2 partials ⚠️
...ediaviewer/impl/details/MediaDetailsBottomSheet.kt 80.00% 0 Missing and 2 partials ⚠️
...ies/mediaviewer/impl/gallery/MediaGalleryEvents.kt 0.00% 2 Missing ⚠️
...braries/mediaviewer/impl/viewer/MediaViewerView.kt 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4071      +/-   ##
===========================================
- Coverage    83.11%   83.10%   -0.02%     
===========================================
  Files         1872     1872              
  Lines        48724    48723       -1     
  Branches      5698     5704       +6     
===========================================
- Hits         40498    40491       -7     
  Misses        6187     6187              
- Partials      2039     2045       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bmarty bmarty merged commit 26ffb1e into develop Dec 20, 2024
24 of 26 checks passed
@bmarty bmarty deleted the feature/bma/galleryUiTweak branch December 20, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants