-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media gallery UI update #4071
Media gallery UI update #4071
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Color.White, | ||
) | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this, it has to render correctly on light theme too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bg for the info (picto + duration) displayed above the video thumbnail.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4071 +/- ##
===========================================
- Coverage 83.11% 83.10% -0.02%
===========================================
Files 1872 1872
Lines 48724 48723 -1
Branches 5698 5704 +6
===========================================
- Hits 40498 40491 -7
Misses 6187 6187
- Partials 2039 2045 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Content
Small change on the media gallery following internal sync.
Figma: https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=1732-80010
Also enable the feature in production.
Motivation and context
Improve UI rendering
Screenshots / GIFs
See recorded one.
Tests
Tested devices
Checklist