Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depencies(sdk) : update rust sdk 0.2.72 #4060

Merged
merged 3 commits into from
Dec 18, 2024
Merged

depencies(sdk) : update rust sdk 0.2.72 #4060

merged 3 commits into from
Dec 18, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 17, 2024 •
edited
Loading

Content

What the title says

Motivation and context

Uses #4044

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review December 17, 2024 17:22
@ganfra ganfra requested a review from a team as a code owner December 17, 2024 17:22
@ganfra ganfra requested review from bmarty and removed request for a team December 17, 2024 17:22
@ganfra ganfra added the PR-Dependencies Pull requests that update a dependency file label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RNcAmV

@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 18, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 18, 2024
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 18, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (d9a7e13) to head (0ab0660).
Report is 16 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4060   +/-   ##
========================================
  Coverage    83.09%   83.09%           
========================================
  Files         1871     1871           
  Lines        48768    48775    +7     
  Branches      5722     5722           
========================================
+ Hits         40525    40532    +7     
  Misses        6196     6196           
  Partials      2047     2047

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.../android/features/messages/impl/timeline/model/event/TimelineItemEncryptedContentProvider.kt
@@ -36,7 +36,7 @@ open class TimelineItemEncryptedContentProvider : PreviewParameterProvider<Timel
aTimelineItemEncryptedContent(
data = UnableToDecryptContent.Data.MegolmV1AesSha2(
sessionId = "sessionId",
utdCause = UtdCause.HistoricalMessage,
utdCause = UtdCause.HistoricalMessageAndBackupIsDisabled,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the case HistoricalMessageAndDeviceIsUnverified here? Can be done later be we may forget :)

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 18, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 18, 2024
@bmarty bmarty mentioned this pull request Dec 18, 2024
Closed
1 task
@ganfra ganfra force-pushed the feature/fga/update_rust_sdk_0.2.72 branch from ba9fc85 to ae03c4c Compare December 18, 2024 14:24
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 18, 2024
@ganfra ganfra enabled auto-merge December 18, 2024 14:24
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 18, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 18, 2024
@ganfra ganfra merged commit 38c3989 into develop Dec 18, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/update_rust_sdk_0.2.72 branch December 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganfra @bmarty @BillCarsonFr @ElementBot