Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract voice message player to its own module #4036

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 13, 2024

Content

Extract voice message player to its own module.

Motivation and context

Be able to play a voice message from the media gallery.

Screenshots / GIFs

Tests

There should be no functional change, this PR is just about moving files.

  • Send a voice message
  • Play it from the timeline.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner December 13, 2024 14:43
@bmarty bmarty requested review from ganfra and removed request for a team December 13, 2024 14:43
@bmarty bmarty added the PR-Misc For other changes label Dec 13, 2024
@bmarty bmarty force-pushed the feature/bma/extractVoiceMessagePlayer branch from 865dba2 to f74258d Compare December 13, 2024 14:46
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Vq6JDy

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.00%. Comparing base (b2a9ebb) to head (f74258d).
Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
...player/impl/DefaultVoiceMessagePresenterFactory.kt 0.00% 15 Missing ⚠️
...pl/voicemessages/timeline/VoiceMessagePresenter.kt 0.00% 3 Missing ⚠️
...ibraries/voiceplayer/impl/VoiceMessagePresenter.kt 94.64% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4036      +/-   ##
===========================================
- Coverage    83.05%   83.00%   -0.06%     
===========================================
  Files         1856     1858       +2     
  Lines        48064    48085      +21     
  Branches      5646     5650       +4     
===========================================
- Hits         39920    39913       -7     
- Misses        6145     6168      +23     
- Partials      1999     2004       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 3643ec3 into develop Dec 13, 2024
24 of 26 checks passed
@bmarty bmarty deleted the feature/bma/extractVoiceMessagePlayer branch December 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants