Build SDK for the local hardware #4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's likely that you want to build the SDK to run on the emulator on your machine, so let's default to that, rather than aarch64.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4021 +/- ##
========================================
Coverage 83.01% 83.01%
========================================
Files 1845 1845
Lines 47699 47699
Branches 5632 5632
========================================
Hits 39595 39595
Misses 6108 6108
Partials 1996 1996 ☔ View full report in Codecov by Sentry. |
bmarty
reviewed
Dec 11, 2024
|
bmarty
approved these changes
Dec 12, 2024
| @@ -59,6 +59,13 @@ buildApp=${buildApp:-no} | |||
|
|
|||
| cd "${elementPwd}" | |||
|
|
|||
| default_arch="$(uname -m)-linux-android" | |||
| # On ARM MacOS, `uname -m` returns arm64, but the toolchain is called aarch64 | |||
| default_arch="${default_arch/arm64/aarch64}" | |||
There was a problem hiding this comment.
TIL about this replacement facilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's likely that you want to build the SDK to run on the emulator on your
machine, so let's default to that, rather than aarch64.
Signed-off-by: Richard van der Hoff <[email protected]>
Checklist