Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dm) : remove duplicate LaunchedEffect when opening DM #4012

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 9, 2024

Content

What the title says.

Motivation and context

Improve app :D

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Dec 9, 2024
@ganfra ganfra marked this pull request as ready for review December 9, 2024 19:01
@ganfra ganfra requested a review from a team as a code owner December 9, 2024 19:01
@ganfra ganfra requested review from bmarty and removed request for a team December 9, 2024 19:01
Copy link
Contributor

github-actions bot commented Dec 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MZN3Dh

Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (9dac27a) to head (6ad89fd).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4012   +/-   ##
========================================
  Coverage    83.08%   83.08%           
========================================
  Files         1821     1821           
  Lines        46450    46450           
  Branches      5444     5444           
========================================
  Hits         38594    38594           
  Misses        5946     5946           
  Partials      1910     1910           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
FTR I have checked all the LaunchedEffect that we have on *Node.kt and I did not find any other similar issues.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 10, 2024
@ganfra ganfra enabled auto-merge December 10, 2024 09:40
@ganfra ganfra merged commit 967115b into develop Dec 10, 2024
34 checks passed
@ganfra ganfra deleted the feature/fga/fix_open_dm_twice branch December 10, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants