-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media gallery UI #4010
Media gallery UI #4010
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first remarks and questions
...r/api/src/main/kotlin/io/element/android/libraries/mediaviewer/api/MediaGalleryEntryPoint.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/io/element/android/libraries/mediaviewer/impl/gallery/TimelineMediaItemsFactory.kt
Outdated
Show resolved
Hide resolved
...kotlin/io/element/android/libraries/mediaviewer/impl/gallery/MediaGalleryTimelineProvider.kt
Outdated
Show resolved
Hide resolved
...l/src/main/kotlin/io/element/android/libraries/mediaviewer/impl/gallery/MediaGalleryState.kt
Outdated
Show resolved
Hide resolved
...lement/android/libraries/mediaviewer/impl/gallery/diff/TimelineMediaItemsCacheInvalidator.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/io/element/android/libraries/mediaviewer/impl/gallery/TimelineMediaItemsFactory.kt
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets merge and iterate!
Content
Implement first version of media gallery.
Figma: https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?m=dev
This PR add new screens to be able to see all the media of a room: images and videos as a gallery (grid) and files as a list.
Will be done later:
Motivation and context
Screenshots / GIFs
Tests
From the timeline, click on an image Event.
Click on "info" picto and see the new bottom sheet
From the room detail screen, click on "Media and files"
See the gallery of images, that can be scrolled to load more media. It should load automatically until the page is full or the beginning of the room is reached
long click on an image to see the bottom sheet
click on an image to see it fullscreen
navigate to the file list
test the action on file
click on file
Tested devices
Checklist