Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(room_preview) : catch all exception instead #3989

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 3, 2024

Content

What the title says.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review December 3, 2024 11:52
@ganfra ganfra requested a review from a team as a code owner December 3, 2024 11:52
@ganfra ganfra requested review from bmarty and removed request for a team December 3, 2024 11:52
@ganfra ganfra added the PR-Bugfix For bug fix label Dec 3, 2024
@ganfra ganfra changed the title room preview : catch all exception fix(room_preview) : catch all exception instead Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Zj83mn

Copy link

sonarqubecloud bot commented Dec 3, 2024

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (cfb91be) to head (54b4d02).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3989   +/-   ##
========================================
  Coverage    83.10%   83.10%           
========================================
  Files         1806     1806           
  Lines        45703    45703           
  Branches      5383     5383           
========================================
  Hits         37980    37980           
  Misses        5835     5835           
  Partials      1888     1888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra enabled auto-merge December 3, 2024 12:48
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@ganfra ganfra merged commit 3d5b834 into develop Dec 3, 2024
34 checks passed
@ganfra ganfra deleted the feature/fga/room_preview_crash branch December 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants