Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Login with QR code in release builds. #3646

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 10, 2024

Not to be merged yet, waiting for a product decision @mxandreas

@manuroe
Copy link
Member

manuroe commented Oct 10, 2024

It is mergeable. We decided it at https://matrix.to/#/!BfWqKebOtAfvfQvOIF:matrix.org/$zScGMOJuZIhm588labZ-AGkhtFPX1M7QbcbsnnawwOk?via=matrix.org&via=element.io

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QAskcL

Copy link

@bmarty bmarty added the PR-Change For updates to an existing feature label Oct 10, 2024
@bmarty bmarty marked this pull request as ready for review October 10, 2024 14:06
@bmarty bmarty requested a review from a team as a code owner October 10, 2024 14:06
@bmarty bmarty requested review from jmartinesp and removed request for a team October 10, 2024 14:06
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: !

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (366db47) to head (ab41f2d).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3646   +/-   ##
========================================
  Coverage    82.82%   82.82%           
========================================
  Files         1747     1747           
  Lines        41742    41740    -2     
  Branches      5102     5101    -1     
========================================
- Hits         34572    34571    -1     
  Misses        5355     5355           
+ Partials      1815     1814    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 10, 2024
@bmarty bmarty merged commit 930bbca into develop Oct 10, 2024
33 checks passed
@bmarty bmarty deleted the feature/bma/qrCodeFF branch October 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants