-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Anvil KSP instead of the Square KAPT one #3564
Conversation
implementation(project(":services:analytics:impl")) | ||
implementation(project(":services:analyticsproviders:posthog")) | ||
implementation(project(":services:analyticsproviders:sentry")) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to check this change again, the current file is more recent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah damn, I think the rebase broke it. Thanks, I'll take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
2abbbbe
to
d1cf31a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3564 +/- ##
===========================================
- Coverage 82.69% 81.00% -1.70%
===========================================
Files 1732 1756 +24
Lines 40977 42229 +1252
Branches 4964 5086 +122
===========================================
+ Hits 33886 34207 +321
- Misses 5337 6254 +917
- Partials 1754 1768 +14 ☔ View full report in Codecov by Sentry. |
eed0c79
to
9d05a88
Compare
@@ -19,7 +18,7 @@ import io.element.android.libraries.di.SingleIn | |||
@SingleIn(AppScope::class) | |||
@MergeComponent(AppScope::class) | |||
interface AppComponent : NodeFactoriesBindings { | |||
@Component.Factory | |||
@MergeComponent.Factory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM if CI is happy!
|
Content
Replace Anvil with Anvil KSP fork by ZacSweers.
Reuse the
setupAnvil
function for this.Also add a couple of improvements to fetching the
features
andlibraries
modules for gradle configuration.Motivation and context
Official Anvil has been without a stable release for > 9 months now, and has several broken features.
Besides this, we get:
Tests
Check the project builds and runs fine.
Tested devices
Checklist