Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle impl module template with setupAnvil() call #3563

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jmartinesp
Copy link
Member

Content

What the title says.

Motivation and context

Missing from #3562.

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Sep 30, 2024
@jmartinesp jmartinesp requested a review from bmarty September 30, 2024 12:24
@jmartinesp jmartinesp requested a review from a team as a code owner September 30, 2024 12:24
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@jmartinesp jmartinesp merged commit 48a4a9d into develop Sep 30, 2024
26 checks passed
@jmartinesp jmartinesp deleted the misc/jme/centralise-anvil-setup branch September 30, 2024 12:28
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6CMQgH

Copy link

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (eeec7cc) to head (234c784).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3563   +/-   ##
========================================
  Coverage    82.68%   82.68%           
========================================
  Files         1732     1732           
  Lines        40974    40974           
  Branches      4964     4964           
========================================
  Hits         33879    33879           
  Misses        5341     5341           
  Partials      1754     1754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants