Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline : remove animateItem #3548

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 26, 2024

Content

Remove the animate item modifier on timeline.

Motivation and context

Animation is weird most of the time.

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review September 26, 2024 14:06
@ganfra ganfra requested a review from a team as a code owner September 26, 2024 14:06
@ganfra ganfra requested review from bmarty and removed request for a team September 26, 2024 14:06
@ganfra ganfra added the PR-Misc For other changes label Sep 26, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mRURAt

Copy link

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (c5f5ff3) to head (5a8cfda).
Report is 16 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3548      +/-   ##
===========================================
- Coverage    82.68%   82.68%   -0.01%     
===========================================
  Files         1732     1732              
  Lines        40983    40982       -1     
  Branches      4966     4966              
===========================================
- Hits         33887    33886       -1     
  Misses        5340     5340              
  Partials      1756     1756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 24c7be6 into develop Sep 27, 2024
30 checks passed
@bmarty bmarty deleted the feature/fga/timeline_remove_item_animation branch September 27, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants