Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceId and cleanup. #3442

Merged
merged 3 commits into from
Sep 11, 2024
Merged

DeviceId and cleanup. #3442

merged 3 commits into from
Sep 11, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 11, 2024

Content

Commit per commit:

Motivation and context

Cleaner code, less warnings.

Screenshots / GIFs

NA

Tests

  • Nothing should change.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Sep 11, 2024
@bmarty bmarty requested a review from a team as a code owner September 11, 2024 08:09
@bmarty bmarty requested review from ganfra and removed request for a team September 11, 2024 08:09
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gyEuLL

Copy link

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 11, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 11, 2024
@bmarty bmarty enabled auto-merge September 11, 2024 08:35
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (7549d5f) to head (032e554).
Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
...braries/matrix/api/oidc/AccountManagementAction.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3442   +/-   ##
========================================
  Coverage    82.62%   82.62%           
========================================
  Files         1697     1698    +1     
  Lines        39940    39943    +3     
  Branches      4860     4860           
========================================
+ Hits         32999    33003    +4     
  Misses        5226     5226           
+ Partials      1715     1714    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 5a86582 into develop Sep 11, 2024
33 of 34 checks passed
@bmarty bmarty deleted the feature/bma/deviceId branch September 11, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants