Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables pinned messages feature by default. #3439

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 10, 2024

Content

Just enables the pinned messages feature by default.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review September 10, 2024 11:58
@ganfra ganfra requested a review from a team as a code owner September 10, 2024 11:58
@ganfra ganfra requested review from jmartinesp and removed request for a team September 10, 2024 11:58
@ganfra ganfra added the PR-Change For updates to an existing feature label Sep 10, 2024
@ganfra ganfra changed the title Pinned messages : enabled by default Changes : Enables pinned messages feature by default. Sep 10, 2024
@ganfra ganfra changed the title Changes : Enables pinned messages feature by default. [Changes] Enables pinned messages feature by default. Sep 10, 2024
@ganfra ganfra changed the title [Changes] Enables pinned messages feature by default. Enables pinned messages feature by default. Sep 10, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/SdnvMs

Copy link

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (78d13fc) to head (5dab1fd).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3439      +/-   ##
===========================================
- Coverage    82.61%   82.61%   -0.01%     
===========================================
  Files         1699     1699              
  Lines        39989    39989              
  Branches      4866     4866              
===========================================
- Hits         33036    33035       -1     
  Misses        5233     5233              
- Partials      1720     1721       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra enabled auto-merge September 10, 2024 12:39
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 10, 2024
@ganfra ganfra merged commit f6704b3 into develop Sep 10, 2024
34 checks passed
@ganfra ganfra deleted the feature/fga/pinned_messages_enabled_by_default branch September 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants