Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity reset] Remove instruction to reset identity on another client. #3355

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 29, 2024

Content

Reset identity:

  • Remove instruction to reset identity on other client.
  • Iterate on wording

Motivation and context

Part of #3329

Screenshots / GIFs

See recorded ones.

Tests

  • No behavior change, just observe that the button Lost your recovery key? is gone.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

Copy link
Contributor

github-actions bot commented Aug 29, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2dFbBH

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (004679c) to head (1a8e1a3).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3355      +/-   ##
===========================================
- Coverage    82.69%   82.68%   -0.01%     
===========================================
  Files         1681     1680       -1     
  Lines        39415    39381      -34     
  Branches      4788     4785       -3     
===========================================
- Hits         32594    32563      -31     
+ Misses        5147     5145       -2     
+ Partials      1674     1673       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty changed the title Reset identity iteration - WIP [Identity reset] Remove instruction to reset identity on another client. Aug 29, 2024
@bmarty bmarty added the PR-Change For updates to an existing feature label Aug 29, 2024
@bmarty bmarty marked this pull request as ready for review August 29, 2024 09:14
@bmarty bmarty requested a review from a team as a code owner August 29, 2024 09:14
@bmarty bmarty requested review from ganfra and removed request for a team August 29, 2024 09:14
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 29, 2024
@bmarty bmarty enabled auto-merge August 29, 2024 10:53
Copy link

@bmarty bmarty merged commit 0d6b4bc into develop Aug 29, 2024
27 checks passed
@bmarty bmarty deleted the feature/bma/resetIdentityIteration2 branch August 29, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants