Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.maplibre.gl:android-sdk to v11.2.0 #3347

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 28, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.maplibre.gl:android-sdk 11.1.0 -> 11.2.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 28, 2024 04:35
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Aug 28, 2024
@renovate renovate bot requested review from ganfra and removed request for a team August 28, 2024 04:35
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/XPsDrc

Copy link

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (d6f194b) to head (efea19b).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3347   +/-   ##
========================================
  Coverage    82.70%   82.70%           
========================================
  Files         1681     1681           
  Lines        39406    39406           
  Branches      4785     4785           
========================================
  Hits         32589    32589           
  Misses        5143     5143           
  Partials      1674     1674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 3c30a9c into develop Aug 28, 2024
29 checks passed
@bmarty bmarty deleted the renovate/org.maplibre.gl-android-sdk-11.x branch August 28, 2024 07:55
@frebib
Copy link
Contributor

frebib commented Aug 28, 2024

Not sure if I'm doing something wrong, but I'm seeing build failures relating (I presume) to this

> Task :app:minifyGplayReleaseWithR8 FAILED
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in app/build/outputs/mapping/gplayRelease/missing_rules.txt.
ERROR: R8: Missing class com.mapbox.android.gestures.AndroidGesturesManager (referenced from: com.mapbox.android.gestures.AndroidGesturesManager org.maplibre.android.plugins.annotation.DraggableAnnotationController$1.val$androidGesturesManager and 4 other contexts)
Missing class com.mapbox.android.gestures.MoveGestureDetector$OnMoveGestureListener (referenced from: void org.maplibre.android.plugins.annotation.DraggableAnnotationController.<init>(org.maplibre.android.maps.MapView, org.maplibre.android.maps.MapLibreMap, com.mapbox.android.gestures.AndroidGesturesManager, int, int, int, int) and 1 other context)

FAILURE: Build failed with an exception.

where app/build/outputs/mapping/gplayRelease/missing_rules.txt has

-dontwarn com.mapbox.android.gestures.AndroidGesturesManager
-dontwarn com.mapbox.android.gestures.MoveGestureDetector$OnMoveGestureListener

@frebib
Copy link
Contributor

frebib commented Aug 28, 2024

Ah, looks like it was fixed here 1101c8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants