Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK bindings to v0.2.39 #3288

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Aug 9, 2024

Content

  • Update the SDK bindings to v0.2.39.
  • Rework RoomSyncSubscriber to work with the new RoomListService.subscribeToRooms API.

Motivation and context

Adopt new APIs.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 13

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Dependencies Pull requests that update a dependency file label Aug 9, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner August 9, 2024 09:40
@jmartinesp jmartinesp requested review from ganfra and removed request for a team August 9, 2024 09:40
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 9, 2024
@jmartinesp jmartinesp force-pushed the misc/jme/update-sdk-to-0.2.39-and-adapt-code branch from 39eaba8 to efc2325 Compare August 9, 2024 09:51
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6528j4

- Rework `RoomSyncSubscriber` to work with the new `RoomListService.subscribeToRooms` API.
@jmartinesp jmartinesp force-pushed the misc/jme/update-sdk-to-0.2.39-and-adapt-code branch from efc2325 to 4c4526b Compare August 9, 2024 10:16
Copy link

sonarqubecloud bot commented Aug 9, 2024

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (2a79f05) to head (4c4526b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3288   +/-   ##
========================================
  Coverage    82.56%   82.56%           
========================================
  Files         1662     1662           
  Lines        38992    38992           
  Branches      4724     4724           
========================================
  Hits         32193    32193           
  Misses        5133     5133           
  Partials      1666     1666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Member Author

Maestro passed here.

@jmartinesp jmartinesp merged commit 65718b3 into develop Aug 9, 2024
26 checks passed
@jmartinesp jmartinesp deleted the misc/jme/update-sdk-to-0.2.39-and-adapt-code branch August 9, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant