Update dependency org.matrix.rustcomponents:sdk-android to v0.2.33 #3220
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
added
the
PR-Dependencies
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3220 +/- ##
========================================
Coverage 76.14% 76.14%
========================================
Files 1645 1645
Lines 38815 38814 -1
Branches 7517 7517
========================================
Hits 29554 29554
+ Misses 5361 5360 -1
Partials 3900 3900 ☔ View full report in Codecov by Sentry. |
| @@ -104,11 +104,6 @@ class JoinedRoomLoadedFlowNode @AssistedInject constructor( | |||
| inputs.room.subscribeToSync() | |||
| } | |||
| }, | |||
| onPause = { | |||
| appCoroutineScope.launch { | |||
| inputs.room.unsubscribeFromSync() | |||
There was a problem hiding this comment.
unsubscribeFromSync does not exist anymore?
There was a problem hiding this comment.
No, it was removed from the SDK. According to Ivan it should be alright (apparently, unsubscribing is more expensive performance-wise for the server), and I didn't experience any performance issues either.
jmartinesp
deleted the
renovate/org.matrix.rustcomponents-sdk-android-0.x
branch
This PR contains the following updates:
0.2.32->0.2.33Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.