Add support for Picture In Picture for Element Call #3159
Conversation
There was a problem hiding this comment.
LGTM, thanks! I just found a minor issue with the way we handle closing the PiP window, but it may be working as expected: when the window is closed I'd expect the call to be cancelled/hung up, but it actually just closes the window and the call keeps working in background.
| ) | ||
| } | ||
| ) | ||
| if (!pipState.isInPictureInPicture) { |
There was a problem hiding this comment.
Technically you could also pass the web view's coordinates to the PiP code instead so it only renders that part of the activity so the webview wouldn't need a resize. It's more work, so I'm not sure it's really worth it.
| @@ -45,7 +45,7 @@ class BlockedUserViewTest { | |||
| fun `clicking on back invokes back callback`() { | |||
| val eventsRecorder = EventsRecorder<BlockedUsersEvents>(expectEvents = false) | |||
| ensureCalledOnce { callback -> | |||
| rule.setLogoutView( | |||
| rule.setBlockedUsersView( | |||
bmarty
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Test is failing on CI, but working locally: 
Commenting out test for version 24 in 962320a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3159 +/- ##
===========================================
+ Coverage 76.03% 76.11% +0.08%
===========================================
Files 1635 1640 +5
Lines 38608 38671 +63
Branches 7464 7476 +12
===========================================
+ Hits 29354 29435 +81
+ Misses 5366 5339 -27
- Partials 3888 3897 +9 ☔ View full report in Codecov by Sentry. |
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
Type of change
Content
Add support for picture in picture mode for Element Call Activity
Motivation and context
Allow user to keep seeing a call, while navigating in the Element X application or any application installed on the phone.
Screenshots / GIFs
Tests
Note that nothing is sent to the Element Call instance, and so the rendering of the Element Call application is not always optimal. sometimes it renders the other party video (which is fine), sometimes it render the local video loopback, which is not ideal.
Tested devices
Checklist