Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set targetSDK to 34 #3149

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Set targetSDK to 34 #3149

merged 1 commit into from
Jul 9, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 5, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Bump target SDK to 34.

Motivation and context

Ensure that the application is using the latest security rules and be able to release the app after August 31th
Closes #3147

Screenshots / GIFs

NA

Tests

  • Smoke test OK (including incoming call, etc.), but happy to do this just after a release so it can live a few days in the nightlies.

Tested devices

  • Physical
  • Emulator with API 34
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4gaNAe

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 5, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 5, 2024
Copy link

sonarqubecloud bot commented Jul 5, 2024

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (53ff503) to head (35af93d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3149   +/-   ##
========================================
  Coverage    76.03%   76.03%           
========================================
  Files         1635     1635           
  Lines        38608    38608           
  Branches      7464     7464           
========================================
  Hits         29354    29354           
  Misses        5366     5366           
  Partials      3888     3888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty marked this pull request as ready for review July 5, 2024 14:02
@bmarty bmarty requested a review from a team as a code owner July 5, 2024 14:02
@bmarty bmarty requested review from ganfra and removed request for a team July 5, 2024 14:02
@bmarty
Copy link
Member Author

bmarty commented Jul 9, 2024

Let's merge to have it in the next nightlies.

@bmarty bmarty merged commit 9bb1aeb into develop Jul 9, 2024
34 checks passed
@bmarty bmarty deleted the feature/bma/targetSdk34 branch July 9, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target SDK 34
1 participant