-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline : fix text item not refreshed when content change #3123
Timeline : fix text item not refreshed when content change #3123
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I have a couple of comments that might need fixing.
.../io/element/android/features/messages/impl/timeline/components/event/TimelineItemTextView.kt
Show resolved
Hide resolved
.../io/element/android/features/messages/impl/timeline/components/event/TimelineItemTextView.kt
Outdated
Show resolved
Hide resolved
aa820d9
to
f15e9da
Compare
@jmartinesp I made the changes |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3123 +/- ##
===========================================
- Coverage 75.96% 75.95% -0.01%
===========================================
Files 1638 1638
Lines 38629 38630 +1
Branches 7465 7464 -1
===========================================
- Hits 29344 29343 -1
- Misses 5397 5399 +2
Partials 3888 3888 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Type of change
Content
Timeline text item is not refreshed when content changed (ie. edit).
The issue has been introduced by this PR
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist