Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline : fix text item not refreshed when content change #3123

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 1, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Timeline text item is not refreshed when content changed (ie. edit).
The issue has been introduced by this PR

Motivation and context

Screenshots / GIFs

Tests

  • Open room
  • Edit a timeline text item
  • See item being refreshed with the new content

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review July 1, 2024 19:52
@ganfra ganfra requested a review from a team as a code owner July 1, 2024 19:52
@ganfra ganfra requested review from jmartinesp and removed request for a team July 1, 2024 19:52
@ganfra ganfra added PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease. labels Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/fcYsfC

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I have a couple of comments that might need fixing.

@ganfra ganfra force-pushed the feature/fga/fix_timeline_text_item_not_refreshed branch from aa820d9 to f15e9da Compare July 2, 2024 08:29
@ganfra
Copy link
Member Author

ganfra commented Jul 2, 2024

@jmartinesp I made the changes

Copy link

sonarqubecloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (b46f47f) to head (f15e9da).

Files Patch % Lines
.../timeline/components/event/TimelineItemTextView.kt 75.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3123      +/-   ##
===========================================
- Coverage    75.96%   75.95%   -0.01%     
===========================================
  Files         1638     1638              
  Lines        38629    38630       +1     
  Branches      7465     7464       -1     
===========================================
- Hits         29344    29343       -1     
- Misses        5397     5399       +2     
  Partials      3888     3888              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@ganfra ganfra enabled auto-merge July 2, 2024 08:47
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@ganfra ganfra merged commit bc13c24 into develop Jul 2, 2024
29 of 30 checks passed
@ganfra ganfra deleted the feature/fga/fix_timeline_text_item_not_refreshed branch July 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants