Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX on notification setting changes #3022

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 12, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

In the demo below:

  • 2 first screens: ensure that the toggle is updated at the same time that the Progress dialog is hidden. In this case, the process is taking time so there is no need to ensure a minimal process duration.
  • last screen (room notification setting) Ensure that the progress dialog is displayed at least 500ms to avoid flickering.

Motivation and context

Closes #1647

Screenshots / GIFs

NotificationSettingChange

Tests

  • Play with the notification settings.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner June 12, 2024 10:55
@bmarty bmarty requested review from jmartinesp and removed request for a team June 12, 2024 10:55
Copy link
Contributor

github-actions bot commented Jun 12, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/VuMzEo

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (55a1ac4) to head (0233e86).
Report is 1 commits behind head on develop.

Files Patch % Lines
...tificationsettings/RoomNotificationSettingsView.kt 0.00% 1 Missing ⚠️
...ettings/UserDefinedRoomNotificationSettingsView.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3022   +/-   ##
========================================
  Coverage    75.78%   75.79%           
========================================
  Files         1611     1611           
  Lines        38101    38105    +4     
  Branches      7362     7364    +2     
========================================
+ Hits         28875    28880    +5     
  Misses        5373     5373           
+ Partials      3853     3852    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 12, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jun 12, 2024
@bmarty bmarty merged commit 5dfd6b8 into develop Jun 13, 2024
26 checks passed
@bmarty bmarty deleted the feature/bma/notificationSetting branch June 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading spinner when selecting different options on the room notifications setting page
2 participants