-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element Call ringing notifications #2978
Element Call ringing notifications #2978
Conversation
…t-call-ringing-with-telecom
…t-call-ringing-with-telecom
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
) { | ||
ElementTheme { | ||
@Composable | ||
private fun IncomingCallScreen( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe extract to its own file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't thought it was worth it as it's not likely that we'll use it anywhere else, but sure I can do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks, I like to have the files containing an Activity as short as possible.
…tyle` notifications. This way they're part of the conversation and are useful for the conversation API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've no particular remark on the code, it looks good.
Lets try to fix the edge cases now!
|
And several other flags for retrocompatibility
Type of change
Content
CallNotify
event type: when a push notification with an event of this type has aCallNotifyType.RING
(DMs) and it was created <10s ago it'll make the phone ring. In any other cases, such as the room not being a DM or the call starting >= 10s ago it'll just add a new normal notification.IncomingCallForegroundService
which will keep the app alive and display the ringing notification and, on a locked device, display the new incoming call screen.CallNotify
event will be sent to the other members of the room when a user joins a call.Motivation and context
Closes #2894 .
Screenshots / GIFs
In the PR.
Tests
CallNotify
event type is also added here.Tested devices
Checklist