Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the keyboard (and keep it opened) when creating a poll. #2381

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 12, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Open the keyboard (and keep it opened) when creating a poll.

The Poll screen correctly requestFocus on the question field, but actually the keyboard was hidden later from the MessagesView.

Actually replace a Disposable effect by a action to close the keyboard in the onBackPressed callback.

Motivation and context

Closes #2329

Screenshots / GIFs

Tests

  • Start a poll from a timeline and observe that the keyboard is opened and stays opened
  • Go back to the timeline
  • Click on the composer to open the keyboard
  • Click on back top start action to go back to the room list
  • observe that the keyboard is closed automatically (so no regression on this)

I did more test to see if the keyboard may stay open when it should not, but I did not find any case with that.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Actually replace a Disposable effect by a action to close the keyboard in the `onBackPressed` callback.
@bmarty bmarty requested a review from a team as a code owner February 12, 2024 14:24
@bmarty bmarty requested review from jmartinesp and removed request for a team February 12, 2024 14:24
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TTvBHk

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bmarty bmarty merged commit 896bd41 into develop Feb 12, 2024
14 checks passed
@bmarty bmarty deleted the feature/bma/pollKeyboard branch February 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard disappears when creating a new poll
2 participants