Do not crash on UP unregistered

[SpiritCroc]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Motivation and context

Fixes #2304

Tests

• Register Ntfy as push distributor
• Remove subscription from the Ntfy app

Tested devices

Tested on SchildiChat-Next only (Oneplus 5 Android 13), but should be simple enough

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

Sign-off

Signed-off-by: Tobias Büttner [email protected]

[bmarty]

Thanks for removing this.
I have checked on my side that when the app is started again, a new registration occured. But I did not get any Push from UnifiedPush, is it working correclty on your side @SpiritCroc ?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4cde9b) 70.07% compared to head (f93c962) 70.08%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2334   +/-   ##
========================================
  Coverage    70.07%   70.08%           
========================================
  Files         1352     1352           
  Lines        33243    33242    -1     
  Branches      6875     6875           
========================================
  Hits         23296    23296           
+ Misses        6633     6632    -1     
  Partials      3314     3314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SpiritCroc]

Thanks for removing this. I have checked on my side that when the app is started again, a new registration occured. But I did not get any Push from UnifiedPush, is it working correclty on your side @SpiritCroc ?

I'm currently able to receive pushs from my self-hosted ntfy just fine from what I can tell. I think I had to reinstall (or rather adb shell pm disable, adb shell pm enable) the distributor app to temporarily switch the app to a different distributor and properly reregister for something I was doing today, but I don't remember if it was related to this issue or just me playing around with the UP-FOSS-FCM-library.