Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Strings #2309

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Sync Strings #2309

merged 1 commit into from
Jan 29, 2024
+34 −2

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot requested a review from a team as a code owner January 29, 2024 00:09
@ElementBot ElementBot requested review from bmarty and removed request for a team January 29, 2024 00:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3vH6Yi

@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6194f2c) 70.07% compared to head (7b0dcbe) 70.07%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2309   +/-   ##
========================================
  Coverage    70.07%   70.07%           
========================================
  Files         1353     1353           
  Lines        33236    33236           
  Branches      6877     6877           
========================================
  Hits         23291    23291           
  Misses        6638     6638           
  Partials      3307     3307

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

libraries/ui-strings/src/main/res/values-zh-rTW/translations.xml
@@ -48,7 +48,7 @@
<string name="action_forgot_password">"忘記密碼？"</string>
<string name="action_forward">"轉寄"</string>
<string name="action_invite">"邀請"</string>
<string name="action_invite_friends">"邀請朋友"</string>
<string name="action_invite_friends">"邀請夥伴"</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@bmarty bmarty merged commit 5b0268a into develop Jan 29, 2024
16 checks passed
@bmarty bmarty deleted the sync-localazy branch January 29, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElementBot @bmarty