Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues around read receipt #1910

Merged
merged 13 commits into from
Nov 28, 2023
Merged

Fix issues around read receipt #1910

merged 13 commits into from
Nov 28, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 28, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR fixes several issues around read receipt:

  • make the RR list scrollable in the bottom sheet of RR
  • render read receipt for state events
  • render aggregated read receipt for grouped state events. Note that the RRs are not clickable here, the group has to be expanded first.
  • reduce bottom padding of state event (more compact timeline and also less space if there are some RR)
  • add preview for expanded group of state event

Motivation and context

Reliable read receipt feature

Screenshots / GIFs

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner November 28, 2023 14:16
@bmarty bmarty requested review from julioromano and removed request for a team November 28, 2023 14:16
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ovp5Tn

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (4de256b) 66.48% compared to head (bc60abd) 66.57%.
Report is 4 commits behind head on develop.

Files Patch % Lines
...imeline/components/TimelineItemGroupedEventsRow.kt 80.82% 8 Missing and 6 partials ⚠️
...ents/receipt/bottomsheet/ReadReceiptBottomSheet.kt 27.77% 10 Missing and 3 partials ⚠️
...ssages/impl/timeline/components/TimelineItemRow.kt 81.35% 7 Missing and 4 partials ⚠️
...l/timeline/components/TimelineItemStateEventRow.kt 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1910      +/-   ##
===========================================
+ Coverage    66.48%   66.57%   +0.08%     
===========================================
  Files         1308     1310       +2     
  Lines        33058    33138      +80     
  Branches      7084     7097      +13     
===========================================
+ Hits         21979    22061      +82     
+ Misses        7724     7717       -7     
- Partials      3355     3360       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 28, 2023
Copy link

@julioromano julioromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a question, in: 40c91a8
Where is the actual background worker?

@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 28, 2023
@bmarty bmarty merged commit 76d6d1f into develop Nov 28, 2023
@bmarty bmarty deleted the feature/bma/fixRRscroll branch November 28, 2023 16:45
@bmarty
Copy link
Member Author

bmarty commented Nov 28, 2023

LGTM Just a question, in: 40c91a8 Where is the actual background worker?

TimelineItemGrouper.kt is used by the Factory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants