Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin duration and MimeTypes #1903

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Kotlin duration and MimeTypes #1903

merged 2 commits into from
Nov 28, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 27, 2023

Small clean up.

…`Duration` in `TimelineItemVideoContent`, like in `TimelineItemAudioContent` and `TimelineItemVoiceContent`
@bmarty bmarty requested a review from a team as a code owner November 27, 2023 20:59
@bmarty bmarty requested review from jmartinesp and removed request for a team November 27, 2023 20:59
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4QFqzH

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8436fc) 66.44% compared to head (1df3817) 66.44%.

Files Patch % Lines
...ctories/event/TimelineItemContentMessageFactory.kt 0.00% 0 Missing and 1 partial ⚠️
...droid/libraries/androidutils/system/SystemUtils.kt 0.00% 1 Missing ⚠️
.../libraries/mediaupload/AndroidMediaPreProcessor.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1903   +/-   ##
========================================
  Coverage    66.44%   66.44%           
========================================
  Files         1308     1308           
  Lines        33059    33059           
  Branches      7087     7087           
========================================
  Hits         21966    21966           
  Misses        7733     7733           
  Partials      3360     3360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 02fa7bb into develop Nov 28, 2023
@bmarty bmarty deleted the feature/bma/kotlinDuration branch November 28, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants