-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run 'record screenshots' flow if label is present #1860
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
f9789fe
to
b428f01
Compare
6fc2cc1
to
0bd080d
Compare
7882cbe
to
086a24e
Compare
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1860 +/- ##
========================================
Coverage 63.61% 63.61%
========================================
Files 1314 1314
Lines 34292 34292
Branches 7104 7104
========================================
Hits 21816 21816
Misses 9228 9228
Partials 3248 3248 ☔ View full report in Codecov by Sentry. |
|
||
steps: | ||
- name: ⏬ Checkout with LFS | ||
- name: Remove Record-Screenshots label | ||
if: github.event.label.name == 'Record-Screenshots' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean it's going to remove the label as soon as it begins work?
What if we display status with labels too?
It could remove this and add "Screenshot-pending" label while the GH action is ongoing (or maybe it could simply add a comment to the PR with a link to the job?)
And it could add the "Screenshots_recorded" label when finished successfully (and a "Screenshot_error" if something wrong happened?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can already see all this in the action list at the bottom of the PR, in the list of actions running/finished: while the screenshots are being recorded, a new "Recording screenshots" job is added, and if it fails it will appear there as failed too AFAICT. If it succeeds, you'll just get a new commit in the PR.
Type of change
Content
Runs 'Record screenshot' GH Actions flow when
Run-Screenshots
label is present.Motivation and context
It's an easier way to trigger screenshots from the PR.
Tests
The screenshots were successfully added to this PR.
Tested devices
Checklist