Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 'record screenshots' flow if label is present #1860

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Nov 22, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Runs 'Record screenshot' GH Actions flow when Run-Screenshots label is present.

Motivation and context

It's an easier way to trigger screenshots from the PR.

Tests

The screenshots were successfully added to this PR.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
Copy link
Contributor

github-actions bot commented Nov 22, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/X5zFk5

@jmartinesp jmartinesp force-pushed the misc/jme/run-record-screenshots-on-label branch from f9789fe to b428f01 Compare November 22, 2023 15:48
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@jmartinesp jmartinesp force-pushed the misc/jme/run-record-screenshots-on-label branch from 6fc2cc1 to 0bd080d Compare November 22, 2023 15:59
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 22, 2023
@jmartinesp jmartinesp marked this pull request as ready for review November 22, 2023 16:23
@jmartinesp jmartinesp requested a review from a team as a code owner November 22, 2023 16:23
@jmartinesp jmartinesp requested review from julioromano and removed request for a team November 22, 2023 16:23
@jmartinesp jmartinesp force-pushed the misc/jme/run-record-screenshots-on-label branch from 7882cbe to 086a24e Compare November 22, 2023 16:27
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc5c02c) 63.61% compared to head (086a24e) 63.61%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1860   +/-   ##
========================================
  Coverage    63.61%   63.61%           
========================================
  Files         1314     1314           
  Lines        34292    34292           
  Branches      7104     7104           
========================================
  Hits         21816    21816           
  Misses        9228     9228           
  Partials      3248     3248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


steps:
- name: ⏬ Checkout with LFS
- name: Remove Record-Screenshots label
if: github.event.label.name == 'Record-Screenshots'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it's going to remove the label as soon as it begins work?
What if we display status with labels too?
It could remove this and add "Screenshot-pending" label while the GH action is ongoing (or maybe it could simply add a comment to the PR with a link to the job?)
And it could add the "Screenshots_recorded" label when finished successfully (and a "Screenshot_error" if something wrong happened?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can already see all this in the action list at the bottom of the PR, in the list of actions running/finished: while the screenshots are being recorded, a new "Recording screenshots" job is added, and if it fails it will appear there as failed too AFAICT. If it succeeds, you'll just get a new commit in the PR.

@jmartinesp jmartinesp merged commit e13b204 into develop Nov 23, 2023
@jmartinesp jmartinesp deleted the misc/jme/run-record-screenshots-on-label branch November 23, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants