Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bma/theme switch #1844

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Feature/bma/theme switch #1844

merged 2 commits into from
Nov 21, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 21, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add option to change the theme: follow system, dark and light.

Motivation and context

Closes #1499

Screenshots / GIFs

See file in the PR

Tests

  • Go to advanced settings and change the theme

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner November 21, 2023 11:23
@bmarty bmarty requested review from jmartinesp and removed request for a team November 21, 2023 11:23
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9hdZSY

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (a8fbb88) 63.55% compared to head (5e95da9) 63.57%.

Files Patch % Lines
.../preferences/impl/advanced/AdvancedSettingsView.kt 52.00% 8 Missing and 4 partials ⚠️
...nt/android/features/call/ui/ElementCallActivity.kt 0.00% 7 Missing ⚠️
.../io/element/android/libraries/theme/theme/Theme.kt 46.15% 7 Missing ⚠️
...c/main/kotlin/io/element/android/x/MainActivity.kt 0.00% 6 Missing ⚠️
.../preferences/impl/store/DefaultPreferencesStore.kt 0.00% 4 Missing ⚠️
...erences/impl/advanced/AdvancedSettingsPresenter.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1844      +/-   ##
===========================================
+ Coverage    63.55%   63.57%   +0.01%     
===========================================
  Files         1312     1313       +1     
  Lines        34127    34201      +74     
  Branches      7078     7091      +13     
===========================================
+ Hits         21689    21742      +53     
- Misses        9206     9217      +11     
- Partials      3232     3242      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool, thanks! I love how simple the implementation is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow selecting dark/light theme in settings
2 participants