-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice message recording duration indicator and limit #1628
Conversation
ba7cf44
to
4c1d431
Compare
3ca7865
to
41f4b2d
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1628 +/- ##
========================================
Coverage 59.24% 59.25%
========================================
Files 1246 1248 +2
Lines 32286 32290 +4
Branches 6627 6622 -5
========================================
+ Hits 19128 19132 +4
Misses 10286 10286
Partials 2872 2872
☔ View full report in Codecov by Sentry. |
e58356f
to
dae5a38
Compare
… jonny/voice-message-sending-duration
Kudos, SonarCloud Quality Gate passed! |
* | ||
* @return the formatted duration. | ||
*/ | ||
fun Duration.formatShort(): String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmarty Is there already amodule for such utilities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about putting it in libraries:core
but it felt a bit too low level for this extension. And I thought libraries:ui-utils
could start to grow with some common Compose utilities too (e.g. SoftKeyboardEffect
which I didn't find a proper home for).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be in the designsystem
module, as per thinks for modifiers.
But we can update this later.
Type of change
Content
Motivation and context
element-hq/element-meta#2084
Screenshots / GIFs
Tests
Tested devices
Checklist