Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup #1487

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Small cleanup #1487

merged 5 commits into from
Oct 5, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 4, 2023

See commit messages for the details.

@bmarty bmarty requested a review from a team as a code owner October 4, 2023 07:44
@bmarty bmarty requested review from ganfra and removed request for a team October 4, 2023 07:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/UzJJUK

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9b18511) 58.40% compared to head (d633052) 58.41%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1487   +/-   ##
========================================
  Coverage    58.40%   58.41%           
========================================
  Files         1133     1133           
  Lines        30281    30282    +1     
  Branches      6201     6203    +2     
========================================
+ Hits         17686    17688    +2     
+ Misses        9943     9942    -1     
  Partials      2652     2652           
Files Coverage Δ
...roid/features/analytics/impl/AnalyticsOptInView.kt 66.66% <ø> (ø)
.../android/features/ftue/impl/welcome/WelcomeView.kt 80.35% <ø> (ø)
...atures/verifysession/impl/VerifySelfSessionView.kt 65.18% <ø> (-0.26%) ⬇️
...ignsystem/atomic/molecules/InfoListItemMolecule.kt 78.57% <ø> (ø)
.../designsystem/atomic/organisms/InfoListOrganism.kt 68.42% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit dea8748 into develop Oct 5, 2023
@bmarty bmarty deleted the feature/bma/uiCleanup branch October 5, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants