Element call url param

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Pass parameter appPrompt and confineToRoom in the fragment part of the URL

FTR: iOS PR: element-hq/element-x-ios#1833

Motivation and context

Better Element Call URL. Those parameters does not need to reach the server.

Screenshots / GIFs

Tests

• Just updated the unit test.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xWYwPx

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5b3d340) 58.38% compared to head (566f096) 58.40%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1477      +/-   ##
===========================================
+ Coverage    58.38%   58.40%   +0.02%     
===========================================
  Files         1133     1133              
  Lines        30264    30281      +17     
  Branches      6196     6201       +5     
===========================================
+ Hits         17669    17686      +17     
  Misses        9943     9943              
  Partials      2652     2652              

Files	Coverage Δ
...ment/android/features/call/CallIntentDataParser.kt	95.23% <100.00%> (+3.23%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbkr]

Looks okay I think, although if it were me I would probably try to use Android's query string parsing/building to do the work, even though this is really awkward because 1. they only work on whole URLs for some reason, so you'd have to construct an intermediate fake URL builder with the fragment query as the real query string, using that to build a query string and 2. the classes to read and build URLs are separate so you'd need one of each to examine the old fragment query string and one to create the edited one.

I think this is okay though, might just behave oddly if it were given params with no values or something.

[bmarty]

Looks okay I think, although if it were me I would probably try to use Android's query string parsing/building to do the work, even though this is really awkward because 1. they only work on whole URLs for some reason, so you'd have to construct an intermediate fake URL builder with the fragment query as the real query string, using that to build a query string and 2. the classes to read and build URLs are separate so you'd need one of each to examine the old fragment query string and one to create the edited one.

I think this is okay though, might just behave oddly if it were given params with no values or something.

I agree, there is lots of manual stuff, this is not ideal. Unit tests are helping to reassures us. One other thing, the Uri builder will URL-encode the fragment, and I do not think we want this...