Ensure http url entered by the user are provided to the SDK without being altered

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Ensure http url entered by the user are provided to the SDK without being altered
• Also change values in LoginConstants, this was not really correct.

Motivation and context

Be able to connect on a http homeserver.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[bmarty]

Ideally this should be reworked a bit, by encapsulating AccountProvider in a sealed interface to properly handle the Other case.

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nRe91v

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (64ae971) 57.91% compared to head (55a9d30) 57.91%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1443   +/-   ##
========================================
  Coverage    57.91%   57.91%           
========================================
  Files         1129     1129           
  Lines        30044    30046    +2     
  Branches      6144     6144           
========================================
+ Hits         17399    17401    +2     
  Misses       10036    10036           
  Partials      2609     2609           

Files	Coverage Δ
...ures/login/impl/accountprovider/AccountProvider.kt	100.00% <100.00%> (ø)
...in/impl/accountprovider/AccountProviderProvider.kt	100.00% <100.00%> (ø)
...eaccountprovider/ChangeAccountProviderPresenter.kt	85.71% <100.00%> (ø)
...changeaccountprovider/ChangeAccountProviderView.kt	67.92% <100.00%> (+0.61%)	⬆️
...accountprovider/ConfirmAccountProviderPresenter.kt	89.47% <100.00%> (ø)
...ountprovider/SearchAccountProviderStateProvider.kt	95.45% <100.00%> (ø)
...searchaccountprovider/SearchAccountProviderView.kt	52.43% <100.00%> (ø)
...android/features/login/impl/util/LoginConstants.kt	83.33% <100.00%> (ø)
...s/login/impl/changeserver/ChangeServerPresenter.kt	80.00% <0.00%> (ø)
...firmaccountprovider/ConfirmAccountProviderState.kt	87.50% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication