Remove usage of async-uniffi #1386
Conversation
ganfra
requested review from
julioromano and
bmarty
and removed request for
a team
ganfra
added
the
Z-NextRelease
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1386 +/- ##
===========================================
- Coverage 57.78% 57.76% -0.02%
===========================================
Files 1125 1125
Lines 29593 29603 +10
Branches 6030 6031 +1
===========================================
Hits 17100 17100
- Misses 9914 9924 +10
Partials 2579 2579
☔ View full report in Codecov by Sentry. |
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
| buildList { | ||
| while (true) { | ||
| // Loading the whole membersIterator as a stop-gap measure. | ||
| // We should probably implement some sort of paging in the future. | ||
| yield() | ||
| ensureActive() |
There was a problem hiding this comment.
What difference does this make in practice?
(yield calls ensureActive internally)
There was a problem hiding this comment.
The yield is not working on this scenario, not sure why. Dont have time to investigate more.
Closes #1381
This might have fixed the deadlock from #1235