-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linkify raw links in HTML message contents #1102
Linkify raw links in HTML message contents #1102
Conversation
- Creates a `ClickableLinkText` for `String`. - Adds a `linkify` parameter to the original function, which is `true` by default. - Does the linkify logic inside that component, if `linkify` is true.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1102 +/- ##
========================================
Coverage 57.09% 57.10%
========================================
Files 1019 1019
Lines 25894 25917 +23
Branches 5192 5203 +11
========================================
+ Hits 14785 14800 +15
- Misses 8835 8837 +2
- Partials 2274 2280 +6
☔ View full report in Codecov by Sentry. |
...em/src/main/kotlin/io/element/android/libraries/designsystem/components/ClickableLinkText.kt
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes
ClickableLinkText
forString
.linkify
parameter to the original function, which istrue
by default.linkify
is true.Why
Fixes #1079.
Screenshots