Improve implementation, add some comments to clarify how it works.

element-hq · Jul 18, 2024 · 0813fe9 · 0813fe9
1 parent 9cc62bd
commit 0813fe9
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/...all/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt b/...all/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt
@@ -192,17 +192,22 @@ class DefaultActiveCallManager @Inject constructor(
 
     @OptIn(ExperimentalCoroutinesApi::class)
     private fun observeRingingCall() {
+        // This will observe ringing calls and ensure they're terminated if the room call is cancelled
         activeCall
             .filterNotNull()
             .filter { it.callState is CallState.Ringing && it.callType is CallType.RoomCall }
             .flatMapLatest { activeCall ->
                 val callType = activeCall.callType as CallType.RoomCall
+                // Get a flow of updated `hasRoomCall` values for the room
                 matrixClientProvider.getOrRestore(callType.sessionId).getOrNull()
                     ?.getRoom(callType.roomId)
-                    ?.roomInfoFlow ?: flowOf()
+                    ?.roomInfoFlow
+                    ?.map { it.hasRoomCall }
+                    ?: flowOf()
             }
-            .map { it.hasRoomCall }
+            // We only want to check if the room active call status changes
             .distinctUntilChanged()
+            // Skip the first one, we're not interested in it (if the check below passes, it had to be active anyway)
             .drop(1)
             .onEach { roomHasActiveCall ->
                 if (!roomHasActiveCall) {