Room List - Store sorted rooms in skip list #29345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data structure stores rooms in a given sorted order and allows for very fast insertions and deletions.
We don't want the store to be created if the labs flag is off
MidhunSureshR
commented
Feb 25, 2025
| import { RecencySorter } from "./skip-list/sorters/RecencySorter"; | ||
| import { AlphabeticSorter } from "./skip-list/sorters/AlphabeticSorter"; | ||
|
|
||
| export class RoomListStoreV3Class extends AsyncStoreWithClient<EmptyObject> { |
There was a problem hiding this comment.
I've added this class so that we can create a minimal view model for the UI work. I will implement the onAction method for dealing with updates after I get filters and spaces working.
There was a problem hiding this comment.
I've moved the store to #29357
Probably best to include this PR with the minimal vm implmentation
MidhunSureshR
changed the title
t3chguy
reviewed
Feb 25, 2025
Skip lists as just as fast as trees but so much easier to implement and reason about. No rebalancing necessary etc.. |
t3chguy
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a skip list to sort and store a given array of rooms. Insertion and deletion into the sorted list is very performant.
https://en.wikipedia.org/wiki/Skip_list