First step to add header to new room list #29320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
changed the title
florianduros
force-pushed
the
florianduros/new-room-list/header
branch
from
b2e0c51 to
b86effa
Compare
florianduros
commented
Feb 19, 2025
Comment on lines
29
to
37
| <Flex | ||
| as="header" | ||
| className="mx_RoomListHeaderView" | ||
| aria-label={_t("room|context_menu|title")} | ||
| justify="space-between" | ||
| align="center" | ||
| > | ||
| <h1>{vm.title}</h1> |
There was a problem hiding this comment.
I'm not sure about the header and h1 tag here in terms of a11y. Is it better to have an aside instead (like in the current room list)?
florianduros
changed the title
florianduros
changed the title
florianduros
force-pushed
the
florianduros/new-room-list/header
branch
from
b86effa to
6d796b0
Compare
florianduros
commented
Feb 20, 2025
|
|
||
| /** | ||
| * View model for the RoomListHeader. | ||
| * The actions don't work when called in a space yet. |
There was a problem hiding this comment.
This will change when we will implement the menu for the spaces. Until it's implemented, the menu is not render for spaces and the actions are not called.
florianduros
commented
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma design
This PR is a first step to add the header of the new room list:
This PR doesn't implement all the features of the design:
Visual
Screen.Recording.2025-02-19.at.15.22.08.mov