Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key storage toggle to Encryption settings #29310

Open
wants to merge 84 commits into
base: develop
Choose a base branch
from
Open

Add key storage toggle to Encryption settings #29310

wants to merge 84 commits into from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 18, 2025

#29113 minus a couple of things that got split out

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

dbkr added 30 commits January 27, 2025 16:56
@dbkr
Add key storage toggle to Encryption settings
5a74298
@dbkr
Keys in the acceptable order
98950de
@dbkr
Fix some tests
4eb07d4
@dbkr
Fix import
97057de
@dbkr
Fix toast showing condition
4ec09f0
@dbkr
Fix import order
4db196e
@dbkr
Fix playwright tests
98114c8
@dbkr
Merge remote-tracking branch 'origin/develop' into dbkr/key_storage_t…
6a20703 
…oggle
@dbkr
Fix bits lost in merge
b7b2ea3
@dbkr
Add key storage delete confirm screen
e408715
@dbkr
Fix hardcoded Element string
aa6de76
@dbkr
Fix type imports
5ac2004
@dbkr
Fix tests
1304587
@dbkr
Tests for key storage delete panel
a26efc5
@dbkr
Fix test
1b99071
@dbkr
Type import
6b238d1
@dbkr
Test for the view model
87d44a7
@dbkr
Merge remote-tracking branch 'origin/develop' into dbkr/key_storage_t…
4ea6a33 
…oggle
@dbkr
Fix type import
df4c23b
@dbkr
Actually fix type imports
4a3a373
@dbkr
Test updating
e70afdb
@dbkr
Add playwright test & clarify slightly confusing comment
40f9bd9
@dbkr
Show the advnced section whatever the state of key storage
16c76cb
@dbkr
Update screenshots
f818d6e
@dbkr
Copy css to its own file
fc9bc09
@dbkr
Add missing doc & merge loading states
25f8fe2
@dbkr
Add tsdoc & loading alt text to spinner
1178d77
@dbkr
Turn comments into proper tsdoc
7c2d9f4
@dbkr
Switch to TypedEventEmitter and remove unnecessary loading state
cfd55a6
@dbkr
Add screenshot
f586c43
dbkr and others added 3 commits March 4, 2025 16:15
@dbkr
Merge branch 'develop' into dbkr/key_storage_toggle_2
dbd8743
@dbkr
Switch to getActiveBackupVersion
33a8edb 
which checks that key backup is happining on this device, which is
consistent with EX.
@dbkr @richvdh
Add use of Key Storage Panel
9e6aa26 
Co-authored-by: Richard van der Hoff <[email protected]>
dbkr and others added 4 commits March 4, 2025 16:25
@dbkr
Change key storage panel to be consistent
7b379a6 
ie. using getActiveBackupVersion(), and add comment
@dbkr @richvdh
Add tsdoc
f68276c 
Co-authored-by: Richard van der Hoff <[email protected]>
@dbkr
Use BACKUP_DISABLED_ACCOUNT_DATA_KEY in more places
cf7fe04
@dbkr @richvdh
Expand doc
9cb8a55 
Co-authored-by: Richard van der Hoff <[email protected]>
@dbkr dbkr requested a review from richvdh March 6, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy left review comments

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@richvdh richvdh Awaiting requested review from richvdh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbkr @richvdh @t3chguy